Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all files when disabling extension #1270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove all files when disabling extension #1270

wants to merge 2 commits into from

Conversation

rastersoft
Copy link

If the extension is uninstalled, the DBus file and others
remain in the system. This can cause problems to other programs
that interact with GSConnect.

This patch fixes this issue by removing all the files when the
extension is disabled, and recreating them when it is enabled.

Fix #1269

@rastersoft
Remove all files when disabling extension
3bf8d4d 
If the extension is uninstalled, the DBus file and others
remain in the system. This can cause problems to other programs
that interact with GSConnect.

This patch fixes this issue by removing all the files when the
extension is disabled, and recreating them when it is enabled.

Fix GSConnect#1269
@rastersoft
Added "unlock-dialog" mode
8e7ba7e 
This mode allows, in Gnome Shell 42, to avoid disabling the
extension when the system hibernates, and thus avoids all the
I/O needed for deleting and re-creating the files.
@ferdnyc
Copy link
Member

ferdnyc commented Mar 16, 2022

@rastersoft

The DBus service file, sure, that I can get behind. But I'm not so sure it's a good idea to remove the .desktop file(s) and icon(s) every time the extension is disabled. Those files are how the application is identified by the GNOME Shell notifications system. They're also used to populate its entry in the Applications list of the gnome-control-center Notifications pane.

@ferdnyc
Copy link
Member

ferdnyc commented Mar 16, 2022

Yeah, I just tested. Trash the icons and these entries get "broken image" icons. Trash the .desktop files and they disappear entirely, which isn't what we'd want just because the extension is disabled.

Screenshot from 2022-03-16 14-22-51

@rastersoft
Copy link
Author

There must be a way of detecting when the extension is being uninstalled... Give me some time.

@andyholmes andyholmes added the needs review A contribution that needs code review label Aug 5, 2022
@github-actions github-actions bot added the conflicts Pull requests with merge conflicts that need to be resolved label Feb 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those so that the changes can be evaluated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyholmes andyholmes andyholmes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
conflicts Pull requests with merge conflicts that need to be resolved needs review A contribution that needs code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing the extension doesn't remove DBus file and others.
3 participants
@rastersoft @ferdnyc @andyholmes